Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: build on 32bit system #70

Merged

Conversation

adrianchiris
Copy link
Collaborator

build with GOARCH=386 fails with error:

$ GOARCH=386 go build ./...
./sriovnet_aux.go:137:17: u32Mask (untyped int constant 4294967295) overflows int

fix this by modifying u32Mask to be uint32 and proper casting.

build with GOARCH=386 fails with error:

$ GOARCH=386 go build ./...
./sriovnet_aux.go:137:17: u32Mask (untyped int constant 4294967295) overflows int

fix this by modifying u32Mask to be uint32 and proper casting.

Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris adrianchiris requested a review from SchSeba August 22, 2024 06:06
@adrianchiris
Copy link
Collaborator Author

@SchSeba a minor fix. PTAL

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10502741211

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.133%

Totals Coverage Status
Change from base Build 7685596232: 0.0%
Covered Lines: 384
Relevant Lines: 1007

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit f71b8cb into k8snetworkplumbingwg:master Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants